pull: Ignore the cancellable when aborting a transaction
authorJoaquim Rocha <jrocha@endlessm.com>
Mon, 12 Mar 2018 12:24:22 +0000 (13:24 +0100)
committerAtomic Bot <atomic-devel@projectatomic.io>
Mon, 12 Mar 2018 19:18:57 +0000 (19:18 +0000)
commit591f8a68b188e7e9239532e93ed452768589e281
treeb9b0f412340bd891b712cec7b62430a106e0af5b
parent6e9d00dbeb94d6e2248289d6d5bbb5d41de84f01
pull: Ignore the cancellable when aborting a transaction

In ostree_repo_abort_transaction, if we pass a cancellable and it gets
canceled, then the function may fail to fully clean up the transaction
state. This was happening e.g. when the ostree_repo_pull_with_options
call got cancelled.

To fix this, as suggested by Colin Walters, we set the passed
cancellable as NULL, in order for it to be ignored.

https://github.com/ostreedev/ostree/issues/1491

Closes: #1492
Approved by: jlebon
src/libostree/ostree-repo-commit.c